Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.incubator.apache.org
From: DT-Priyanka <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-207-incubator-apex-malhar@git.apache.org>
In-Reply-To: <git-pr-207-incubator-apex-malhar@git.apache.org>
Subject: [GitHub] incubator-apex-malhar pull request: APEXMALHAR-2008: Create
 HDFS F...
Content-Type: text/plain
Message-Id: <20160310091931.7C039DFBDE@git1-us-west.apache.org>
Date: Thu, 10 Mar 2016 09:19:31 +0000 (UTC)

Github user DT-Priyanka commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/207#discussion_r55651968
  
    --- Diff: library/src/main/java/com/datatorrent/lib/io/block/HDFSBlockReader.java ---
    @@ -0,0 +1,78 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package com.datatorrent.lib.io.block;
    +
    +import java.io.IOException;
    +import java.net.URI;
    +
    +import org.apache.hadoop.fs.FileSystem;
    +
    +import com.google.common.base.Splitter;
    +
    +public class HDFSBlockReader extends FSSliceReader
    +{
    +  protected String uri;
    +
    +  @Override
    +  protected FileSystem getFSInstance() throws IOException
    +  {
    +    return FileSystem.newInstance(URI.create(uri), configuration);
    +  }
    +
    +  /**
    +   * Sets the uri
    +   *
    +   * @param uri
    +   */
    +  public void setUri(String uri)
    +  {
    +    this.uri = convertSchemeToLowerCase(uri);
    +  }
    +
    +  public String getUri()
    +  {
    +    return uri;
    +  }
    +
    +  /**
    +   * Converts Scheme part of the URI to lower case. Multiple URI can be comma separated. If no scheme is there, no
    +   * change is made.
    +   * 
    +   * @param
    +   * @return String with scheme part as lower case
    +   */
    +  private static String convertSchemeToLowerCase(String uri)
    --- End diff --
    
    Adding unit test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---