apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXCORE-393) Reset failure count when consecutive failed node is removed from blacklist
Date Tue, 22 Mar 2016 23:36:25 GMT

    [ https://issues.apache.org/jira/browse/APEXCORE-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207530#comment-15207530
] 

ASF GitHub Bot commented on APEXCORE-393:
-----------------------------------------

Github user tweise commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/274#discussion_r57088465
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/StreamingAppMasterService.java ---
    @@ -950,7 +977,11 @@ private void execute() throws YarnException, IOException
     
           if (!blacklistAdditions.isEmpty()) {
             amRmClient.updateBlacklist(blacklistAdditions, null);
    -        blacklistedNodesQueueWithTimeStamp.add(new Pair<Long, List<String>>(System.currentTimeMillis(),
blacklistAdditions));
    +        long timeStamp = System.currentTimeMillis();
    +        for(String hostname : blacklistAdditions) {
    --- End diff --
    
    another nit, space after "for" missing, surprised it passes checkstyle?


> Reset failure count when consecutive failed node is removed from blacklist
> --------------------------------------------------------------------------
>
>                 Key: APEXCORE-393
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-393
>             Project: Apache Apex Core
>          Issue Type: Bug
>            Reporter: Isha Arkatkar
>            Assignee: Isha Arkatkar
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message