apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXMALHAR-1897) Create ManagedState
Date Sun, 20 Mar 2016 16:32:33 GMT

    [ https://issues.apache.org/jira/browse/APEXMALHAR-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15203350#comment-15203350
] 

ASF GitHub Bot commented on APEXMALHAR-1897:
--------------------------------------------

Github user amberarrow commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/145#discussion_r56767189
  
    --- Diff: library/src/main/java/com/datatorrent/lib/state/managed/ManagedTimeStateImpl.java
---
    @@ -0,0 +1,125 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package com.datatorrent.lib.state.managed;
    +
    +import java.util.concurrent.Future;
    +
    +import javax.validation.constraints.Min;
    +
    +import com.google.common.util.concurrent.Futures;
    +
    +import com.datatorrent.api.annotation.OperatorAnnotation;
    +import com.datatorrent.lib.state.BucketedState;
    +import com.datatorrent.lib.state.TimeSlicedBucketedState;
    +import com.datatorrent.netlet.util.Slice;
    +
    +/**
    + * This implementation of {@link ManagedState} lets the client to specify the time for
each key. The value of time
    + * is used to derive the time-bucket of a key.
    + */
    +@OperatorAnnotation(checkpointableWithinAppWindow = false)
    +public class ManagedTimeStateImpl extends AbstractManagedStateImpl implements TimeSlicedBucketedState
    +{
    +  public ManagedTimeStateImpl()
    +  {
    +    this.numBuckets = 1;
    +  }
    +
    +  @Override
    +  public void put(long bucketId, long time, Slice key, Slice value)
    +  {
    +    int bucketIdx = prepareBucket(bucketId);
    +    long timeBucket = timeBucketAssigner.getTimeBucketFor(time);
    +    if (timeBucket != -1) {
    +      buckets[bucketIdx].put(key, timeBucket, value);
    +    }
    +  }
    +
    +  @Override
    +  public Slice getSync(long bucketId, Slice key)
    +  {
    +    int bucketIdx = prepareBucket(bucketId);
    +    return buckets[bucketIdx].get(key, -1, Bucket.ReadSource.ALL);
    +  }
    +
    +  @Override
    +  public Slice getSync(long bucketId, long time, Slice key)
    +  {
    +    int bucketIdx = prepareBucket(bucketId);
    +    long timeBucket = timeBucketAssigner.getTimeBucketFor(time);
    +    if (timeBucket == -1) {
    +      //time is expired so no point in looking further.
    +      return BucketedState.EXPIRED;
    +    }
    +    return buckets[bucketIdx].get(key, timeBucket, Bucket.ReadSource.ALL);
    +  }
    +
    +  @SuppressWarnings("SynchronizationOnLocalVariableOrMethodParameter")
    +  @Override
    +  public Future<Slice> getAsync(long bucketId, Slice key)
    +  {
    +    int bucketIdx = prepareBucket(bucketId);
    +    Bucket bucket = buckets[bucketIdx];
    +    synchronized (bucket) {
    +      Slice cachedVal = buckets[bucketIdx].get(key, -1, Bucket.ReadSource.MEMORY);
    +      if (cachedVal != null) {
    +        return Futures.immediateFuture(cachedVal);
    +      }
    +      return readerService.submit(new KeyFetchTask(bucket, key, -1, throwable));
    +    }
    +  }
    +
    +  @SuppressWarnings("SynchronizationOnLocalVariableOrMethodParameter")
    +  @Override
    +  public Future<Slice> getAsync(long bucketId, long time, Slice key)
    +  {
    +    int bucketIdx = prepareBucket(bucketId);
    +    Bucket bucket = buckets[bucketIdx];
    +    long timeBucket = timeBucketAssigner.getTimeBucketFor(time);
    +    if (timeBucket == -1) {
    +      //time is expired so no point in looking further.
    +      return Futures.immediateFuture(BucketedState.EXPIRED);
    +    }
    +    synchronized (bucket) {
    +      Slice cachedVal = buckets[bucketIdx].get(key, timeBucket, Bucket.ReadSource.MEMORY);
    +      if (cachedVal != null) {
    +        return Futures.immediateFuture(cachedVal);
    +      }
    +      return readerService.submit(new KeyFetchTask(bucket, key, timeBucket, throwable));
    +    }
    --- End diff --
    
    This synchronized block and the assignment to `bucket` are duplicated in multiple places
(3 or 4); could it be factored out to a helper method in the base class ?


> Create ManagedState
> -------------------
>
>                 Key: APEXMALHAR-1897
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-1897
>             Project: Apache Apex Malhar
>          Issue Type: Sub-task
>            Reporter: Chandni Singh
>            Assignee: Chandni Singh
>             Fix For: 3.4.0
>
>
> ManagedState is described in the document below:
> https://docs.google.com/document/d/1gRWN9ufKSZSZD0N-pthlhpC9TZ8KwJ6hJlAX6nxl5f8/edit#heading=h.z87ti1fwyt0t



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message