apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXCORE-10) Enable non-affinity of operators per node (not containers)
Date Sat, 26 Mar 2016 03:03:25 GMT

    [ https://issues.apache.org/jira/browse/APEXCORE-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212756#comment-15212756
] 

ASF GitHub Bot commented on APEXCORE-10:
----------------------------------------

Github user tweise commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/250#discussion_r57508019
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/ContainerRequestHandlerCloudera.java
---
    @@ -0,0 +1,138 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package com.datatorrent.stram;
    +
    +import java.util.ArrayList;
    +import java.util.HashMap;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.Map.Entry;
    +
    +import org.apache.commons.lang.StringUtils;
    +import org.apache.commons.lang3.tuple.MutablePair;
    +import org.apache.hadoop.yarn.client.api.AMRMClient;
    +import org.apache.hadoop.yarn.client.api.AMRMClient.ContainerRequest;
    +
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import com.datatorrent.stram.StreamingContainerAgent.ContainerStartRequest;
    +
    +/**
    + * Handles creating container requests and issuing node-specific container
    + * requests by blacklisting specifically for cloudera
    + */
    +public class ContainerRequestHandlerCloudera extends ContainerRequestHandler
    +{
    +  HashMap<ContainerRequest, ContainerStartRequest> hostSpecificRequests = new HashMap<>();
    +  HashMap<ContainerRequest, ContainerStartRequest> otherContainerRequests = new
HashMap<>();
    +  HashMap<String, List<ContainerRequest>> hostSpecificRequestsMap = new HashMap<>();
    +  List<String> blacklistedNodesForHostSpecificRequests = null;
    +
    +  public void reissueContainerRequests(AMRMClient<ContainerRequest> amRmClient,
Map<StreamingContainerAgent.ContainerStartRequest, MutablePair<Integer, ContainerRequest>>
requestedResources, int loopCounter, ResourceRequestHandler resourceRequestor, List<ContainerRequest>
containerRequests, List<ContainerRequest> removedContainerRequests)
    +  {
    +    // Issue all host specific requests first
    +    if (!hostSpecificRequestsMap.isEmpty() && requestedResources.isEmpty()) {
    +      LOG.info("Issue Host specific requests first");
    +      // Blacklist all the nodes and issue request for host specific
    +      Entry<String, List<ContainerRequest>> set = hostSpecificRequestsMap.entrySet().iterator().next();
    +      List<ContainerRequest> requests = set.getValue();
    +      List<String> blacklistNodes = resourceRequestor.getNodesExceptHost(requests.get(0).getNodes());
    +      amRmClient.updateBlacklist(blacklistNodes, requests.get(0).getNodes());
    +      blacklistedNodesForHostSpecificRequests = blacklistNodes;
    +      LOG.info("Sending {} request(s) after blacklisting nodes {} and removed host from
request {}", requests.size(), blacklistNodes, requests.get(0).getNodes());
    +
    +      for (ContainerRequest cr : requests) {
    +        ContainerStartRequest csr = hostSpecificRequests.get(cr);
    +        ContainerRequest newCr = new ContainerRequest(cr.getCapability(), null, null,
cr.getPriority());
    +        MutablePair<Integer, ContainerRequest> pair = new MutablePair<Integer,
ContainerRequest>(loopCounter, newCr);
    +        requestedResources.put(csr, pair);
    +        containerRequests.add(newCr);
    +        hostSpecificRequests.remove(cr);
    +      }
    +      hostSpecificRequestsMap.remove(set.getKey());
    +    } else if (!requestedResources.isEmpty()) {
    +      // Check if any requests timed out, create new requests in that case
    +      recreateContainerRequest(requestedResources, loopCounter, resourceRequestor, removedContainerRequests);
    +    } else {
    +      if (blacklistedNodesForHostSpecificRequests != null) {
    +        // Remove the nodes blacklisted nodes for host specific requests
    --- End diff --
    
    failed to parse comment :-)


> Enable non-affinity of operators per node (not containers)
> ----------------------------------------------------------
>
>                 Key: APEXCORE-10
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-10
>             Project: Apache Apex Core
>          Issue Type: Task
>            Reporter: Amol Kekre
>            Assignee: Isha Arkatkar
>              Labels: roadmap
>
> The issue happens on cloud which provides virtual cores with software like Xen underneath.
In effect if CPU intensive operators land up on same node we have a resource bottleneck,
> Need to create an attribute that does the following
> - Operators A & B should not be on same node
> - Stram should use this attribute to try to get containers on different node
> It is understood that the user is making an explicit choice to use NIC instead of stream
local optimization



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message