apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tweise <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEXCORE-10 #resolve Changes for...
Date Sat, 26 Mar 2016 04:03:58 GMT
Github user tweise commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/250#discussion_r57508918
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/StreamingAppMasterService.java ---
    @@ -668,7 +671,10 @@ private void execute() throws YarnException, IOException
         int numReleasedContainers = 0;
         int nextRequestPriority = 0;
         ResourceRequestHandler resourceRequestor = new ResourceRequestHandler();
    +    // Use override for container requestor in case of cloudera distribution,to handle
host specific requests
    +    ContainerRequestHandler containerRequestor = System.getenv().containsKey("CDH_HADOOP_BIN")
? new ContainerRequestHandlerCloudera() : new ContainerRequestHandler();
    --- End diff --
    
    Would it makes sense to combine ResourceRequestHandler and ContainerRequestHandler?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message