apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amberarrow <...@git.apache.org>
Subject [GitHub] incubator-apex-malhar pull request: APEXMALHAR-1897 added managed ...
Date Thu, 24 Mar 2016 02:03:31 GMT
Github user amberarrow commented on a diff in the pull request:

    --- Diff: library/src/main/java/com/datatorrent/lib/state/managed/AbstractManagedStateImpl.java
    @@ -226,6 +232,15 @@ protected int prepareBucket(long bucketId)
         return bucketIdx;
    +  protected void putInBucket(long bucketId, long timeBucket, Slice key, Slice value)
    +  {
    +    if (timeBucket != -1) {
    +      //time bucket is invalid data is not stored
    --- End diff --
    Suggest moving comment above the if and rephrasing:
    // if time bucket is invalid, data is not stored

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message