apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chinmaykolhatkar <...@git.apache.org>
Subject [GitHub] incubator-apex-malhar pull request: APEXMALHAR-2011-2012 Avro to P...
Date Fri, 18 Mar 2016 08:18:14 GMT
Github user chinmaykolhatkar commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/211#discussion_r56624094
  
    --- Diff: contrib/src/main/java/com/datatorrent/contrib/avro/AvroRecordHelper.java ---
    @@ -114,6 +107,7 @@ private static Object convertAndResolveUnionToPrimitive(Schema schema,
String ke
             }
             convertedValue = convertValueToAvroPrimitive(types.get(i).getType(), key, value);
           } catch (RuntimeException e) {
    +        LOG.error("Could not handle schema resolution" + e.getMessage());
    --- End diff --
    
    Should this not actually throw to the caller instead of hiding here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message