apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From PramodSSImmaneni <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEXCORE-380 - Idle time sleep t...
Date Thu, 17 Mar 2016 00:46:29 GMT
Github user PramodSSImmaneni commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/271#discussion_r56440964
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/engine/GenericNode.java ---
    @@ -608,9 +610,9 @@ else if (tracker.ports[trackerIndex] == null) {
               if (need2sleep) {
                 if (handleIdleTime && insideWindow) {
                   ((IdleTimeHandler) operator).handleIdleTime();
    -            }
    -            else {
    +            } else {
                   Thread.sleep(spinMillis);
    +              spinMillis = Math.min(maxSpinMillis, spinMillis + 1);
    --- End diff --
    
    I had looked at this before in a difference scenario. Can we do a better heuristic. We
can have another timeout setting (which is less than streaming window size) where we continue
to do busy way till that timeout and if there is no data till then, then initiate the stepwise
sleep.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message