apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chinmaykolhatkar <...@git.apache.org>
Subject [GitHub] incubator-apex-malhar pull request: APEXMALHAR-2008: Create HDFS F...
Date Thu, 10 Mar 2016 06:51:25 GMT
Github user chinmaykolhatkar commented on a diff in the pull request:

    --- Diff: library/src/main/java/com/datatorrent/lib/io/fs/HDFSInputModule.java ---
    @@ -0,0 +1,236 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package com.datatorrent.lib.io.fs;
    +import javax.validation.constraints.Min;
    +import javax.validation.constraints.NotNull;
    +import javax.validation.constraints.Size;
    +import org.apache.commons.lang.mutable.MutableLong;
    +import org.apache.hadoop.conf.Configuration;
    +import com.datatorrent.api.Context;
    +import com.datatorrent.api.DAG;
    +import com.datatorrent.api.Module;
    +import com.datatorrent.common.metric.MetricsAggregator;
    +import com.datatorrent.common.metric.SingleMetricAggregator;
    +import com.datatorrent.common.metric.sum.LongSumAggregator;
    +import com.datatorrent.common.partitioner.StatelessPartitioner;
    +import com.datatorrent.lib.counters.BasicCounters;
    +import com.datatorrent.lib.io.block.AbstractBlockReader.ReaderRecord;
    +import com.datatorrent.lib.io.block.BlockMetadata.FileBlockMetadata;
    +import com.datatorrent.lib.io.block.HDFSBlockReader;
    +import com.datatorrent.lib.io.fs.AbstractFileSplitter.FileMetadata;
    +import com.datatorrent.lib.io.fs.HDFSFileSplitter.HDFSScanner;
    +import com.datatorrent.netlet.util.Slice;
    + * HDFSInputModule is used to read files from HDFS. <br/>
    + * Module emits FileMetadata, BlockMetadata and the block bytes.
    + */
    +public class HDFSInputModule implements Module
    --- End diff --
    Can you please describe what you've mentioned in this PR description as a javadoc in HDFSInputModule?
    Its good to mention in default what all this module is responsible for and also how it'll

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message