apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chaithu14 <...@git.apache.org>
Subject [GitHub] incubator-apex-malhar pull request: Add Idempotent support the new...
Date Wed, 02 Mar 2016 11:21:15 GMT
Github user chaithu14 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/205#discussion_r54710624
  
    --- Diff: kafka/src/main/java/org/apache/apex/malhar/kafka/AbstractKafkaInputOperator.java
---
    @@ -339,6 +394,11 @@ public void assign(Set<AbstractKafkaPartitioner.PartitionMeta>
assignment)
         return assignment;
       }
     
    +  private boolean isIdempotent()
    +  {
    +    return windowDataManager != null && !(windowDataManager instanceof WindowDataManager.NoopWindowDataManager);
    +  }
    --- End diff --
    
    I think HighLevelKafkaConsumer doesn't support emitImmediately. So, this check needs 
to be added in isIdempotent() API. Please correct it, if I am wrong.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message