apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chandnisingh <...@git.apache.org>
Subject [GitHub] incubator-apex-malhar pull request: APEXMALHAR-2004: Add file's mo...
Date Mon, 29 Feb 2016 20:52:25 GMT
Github user chandnisingh commented on a diff in the pull request:

    --- Diff: library/src/main/java/com/datatorrent/lib/io/fs/FileSplitterInput.java ---
    @@ -439,12 +439,12 @@ protected ScannedFileInfo createScannedFileInfo(Path parentPath,
FileStatus pare
           ScannedFileInfo info;
           if (rootPath == null) {
             info = parentStatus.isDirectory() ?
    -          new ScannedFileInfo(parentPath.toUri().getPath(), childPath.getName(), parentStatus.getModificationTime())
    -          new ScannedFileInfo(null, childPath.toUri().getPath(), parentStatus.getModificationTime());
    +          new ScannedFileInfo(parentPath.toUri().getPath(), childPath.getName(), childStatus.getModificationTime())
    +          new ScannedFileInfo(null, childPath.toUri().getPath(), childStatus.getModificationTime());
    --- End diff --
    please remove ```@SuppressWarnings("UnusedParameters")``` with ```childStatus``` in the
method definition

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message