apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhupeshchawda <...@git.apache.org>
Subject [GitHub] incubator-apex-malhar pull request: APEXMALHAR-1985: Using startRo...
Date Mon, 15 Feb 2016 12:10:12 GMT
Github user bhupeshchawda commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/182#discussion_r52891593
  
    --- Diff: contrib/src/test/java/com/datatorrent/contrib/cassandra/CassandraOperatorTest.java
---
    @@ -333,26 +333,26 @@ public void testCassandraInputOperator()
     
         String query2 = "SELECT * FROM " + KEYSPACE + "." + "%t where token(%p) > %v;";
         inputOperator.setQuery(query2);
    +    inputOperator.setStartRow(10);
         inputOperator.setup(context);
         inputOperator.outputPort.setup(tpc);
         inputOperator.activate(context);
     
    -    inputOperator.setStartRow(10);
         inputOperator.beginWindow(1);
         inputOperator.emitTuples();
         inputOperator.endWindow();
    -    Assert.assertEquals("rows from db", 14, sink.collectedTuples.size());
    +    Assert.assertEquals("rows from db", 26, sink.collectedTuples.size());
     
         sink.clear();
         inputOperator.columnDataTypes.clear();
     
         String query3 = "SELECT * FROM " + KEYSPACE + "." + "%t where token(%p) > %v LIMIT
%l;";
         inputOperator.setQuery(query3);
    +    inputOperator.setStartRow(1);
         inputOperator.setup(context);
         inputOperator.outputPort.setup(tpc);
         inputOperator.activate(context);
     
    -    inputOperator.setStartRow(1);
         inputOperator.setLimit(10);
    --- End diff --
    
    Shouldn't setLimit() also be called before activate() ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message