Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.incubator.apache.org
Date: Tue, 26 Jan 2016 23:30:40 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@apex.incubator.apache.org
Message-ID: <JIRA.12933991.1453767340000.218519.1453851040322@Atlassian.JIRA>
In-Reply-To: <JIRA.12933991.1453767340000@Atlassian.JIRA>
References: <JIRA.12933991.1453767340000@Atlassian.JIRA>
 <JIRA.12933991.1453767340329@arcas>
Subject: [jira] [Commented] (APEXMALHAR-1984) Operators that use Kryo
 directly would throw exception in local mode
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/APEXMALHAR-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118271#comment-15118271 ] 

ASF GitHub Bot commented on APEXMALHAR-1984:
--------------------------------------------

Github user siyuanh commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/178#discussion_r50919206
  
    --- Diff: library/src/main/java/com/datatorrent/lib/util/PartitionerUtils.java ---
    @@ -0,0 +1,63 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package com.datatorrent.lib.util;
    +
    +import java.io.ByteArrayOutputStream;
    +
    +import org.apache.commons.io.IOUtils;
    +
    +import com.esotericsoftware.kryo.Kryo;
    +import com.esotericsoftware.kryo.io.Input;
    +import com.esotericsoftware.kryo.io.Output;
    +
    +import com.datatorrent.api.DefaultPartition;
    +import com.datatorrent.api.Operator;
    +
    +/**
    + *
    + * A Partitioner Util class that can be used in definePartition method to create operator from existing one
    + *
    + * @since 3.4.0
    + */
    +public class PartitionerUtils
    --- End diff --
    
    Name it in this way because it is a repeat pattern in definePartition code and developer can easily find this when they want this feature. 


> Operators that use Kryo directly would throw exception in local mode
> --------------------------------------------------------------------
>
>                 Key: APEXMALHAR-1984
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-1984
>             Project: Apache Apex Malhar
>          Issue Type: Bug
>            Reporter: Siyuan Hua
>            Assignee: Siyuan Hua
>


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)