Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.incubator.apache.org
Date: Sat, 30 Jan 2016 03:43:39 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@apex.incubator.apache.org
Message-ID: <JIRA.12933415.1453488376000.255812.1454125419788@Atlassian.JIRA>
In-Reply-To: <JIRA.12933415.1453488376000@Atlassian.JIRA>
References: <JIRA.12933415.1453488376000@Atlassian.JIRA>
 <JIRA.12933415.1453488376087@arcas>
Subject: [jira] [Commented] (APEXMALHAR-1983) Support special chars in
 topics setting for new Kafka Input Operator
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/APEXMALHAR-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15124694#comment-15124694 ] 

ASF GitHub Bot commented on APEXMALHAR-1983:
--------------------------------------------

Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/176#discussion_r51339726
  
    --- Diff: kafka/src/main/java/org/apache/apex/malhar/kafka/AbstractKafkaInputOperator.java ---
    @@ -366,17 +374,19 @@ public String getClusters()
         return Joiner.on(';').join(clusters);
       }
     
    -  public void setTopics(String... topics)
    +  public void setTopics(String topics)
       {
    -    this.topics = topics;
    +    Topic.validate(topics.replace(" |,", "");
    +    this.topics = Iterables.toArray(Splitter.on(',').trimResults().omitEmptyStrings().split(topics), String.class);
    --- End diff --
    
    This assumes that " " is also a valid separator for topics. I think it is better to validate each topic separately.  


> Support special chars in topics setting for new Kafka Input Operator
> --------------------------------------------------------------------
>
>                 Key: APEXMALHAR-1983
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-1983
>             Project: Apache Apex Malhar
>          Issue Type: Improvement
>            Reporter: Siyuan Hua
>            Assignee: Siyuan Hua
>             Fix For: 3.4.0
>
>
> The setter method take string[] as parameter which confuse the json serializer which character as separator. We should convert the string to string[] in setter method. Reserve , as seperator


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)