Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.incubator.apache.org
Date: Tue, 19 Jan 2016 19:31:39 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@apex.incubator.apache.org
Message-ID: <JIRA.12929203.1452525834000.150681.1453231899880@Atlassian.JIRA>
In-Reply-To: <JIRA.12929203.1452525834000@Atlassian.JIRA>
References: <JIRA.12929203.1452525834000@Atlassian.JIRA>
 <JIRA.12929203.1452525834059@arcas>
Subject: [jira] [Commented] (APEXCORE-304) Ability to add jars to classpath
 in populateDAG
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/APEXCORE-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15107261#comment-15107261 ] 

ASF GitHub Bot commented on APEXCORE-304:
-----------------------------------------

Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/208#discussion_r50161978
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/StramLocalCluster.java ---
    @@ -308,6 +313,24 @@ public StramLocalCluster(LogicalPlan dag) throws IOException, ClassNotFoundExcep
         this.dnmgr = new StreamingContainerManager(dag);
         this.umbilical = new UmbilicalProtocolLocalImpl();
     
    +    Method addURL;
    +    URLClassLoader loader;
    +    try {
    +      loader = (URLClassLoader)ClassLoader.getSystemClassLoader();
    --- End diff --
    
    What is the purpose of casting loader to URLCLassLoader? Can't this be coded as
    ```
       ClassLoader loader;
       try {
         loader = ClassLoader.getSystemClassLoader();
         addURL = loader.getClass().getDeclaredMethod("addURL", URL.class);
    ```


> Ability to add jars to classpath in populateDAG
> -----------------------------------------------
>
>                 Key: APEXCORE-304
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-304
>             Project: Apache Apex Core
>          Issue Type: Improvement
>            Reporter: Chinmay Kolhatkar
>            Assignee: Chinmay Kolhatkar
>
> This will have following functionality:
> 1) In populateDAG one would be allowed to add given local jar path to classpath of the application.
> 2) Optionally delete the given jar file after copying to HDFS is done.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)