Return-Path: X-Original-To: apmail-apex-dev-archive@minotaur.apache.org Delivered-To: apmail-apex-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0A2C61877F for ; Fri, 8 Jan 2016 16:35:47 +0000 (UTC) Received: (qmail 46247 invoked by uid 500); 8 Jan 2016 16:35:46 -0000 Delivered-To: apmail-apex-dev-archive@apex.apache.org Received: (qmail 46187 invoked by uid 500); 8 Jan 2016 16:35:46 -0000 Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@apex.incubator.apache.org Delivered-To: mailing list dev@apex.incubator.apache.org Received: (qmail 46176 invoked by uid 99); 8 Jan 2016 16:35:46 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Jan 2016 16:35:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 6DD95C0D2C for ; Fri, 8 Jan 2016 16:35:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.227 X-Spam-Level: * X-Spam-Status: No, score=1.227 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.554, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id EBb-hOx6uFUn for ; Fri, 8 Jan 2016 16:35:40 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with SMTP id 20FA2204D0 for ; Fri, 8 Jan 2016 16:35:40 +0000 (UTC) Received: (qmail 45730 invoked by uid 99); 8 Jan 2016 16:35:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Jan 2016 16:35:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D130A2C1F5C for ; Fri, 8 Jan 2016 16:35:39 +0000 (UTC) Date: Fri, 8 Jan 2016 16:35:39 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@apex.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (APEXCORE-268) Fix existing checkstyle violations in common module MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/APEXCORE-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15089468#comment-15089468 ] ASF GitHub Bot commented on APEXCORE-268: ----------------------------------------- Github user vrozov commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/199#discussion_r49207712 --- Diff: common/src/main/java/com/datatorrent/common/metric/MetricsAggregator.java --- @@ -129,13 +128,13 @@ public void addAggregators(@NotNull String metric, @NotNull SingleMetricAggregat * be used for the result of aggregators[i]. */ public void addAggregators(@NotNull String metric, @NotNull SingleMetricAggregator[] aggregators, - @NotNull String[] logicalMetricNames) + @NotNull String[] logicalMetricNames) { Preconditions.checkNotNull(metric, "metric"); Preconditions.checkNotNull(aggregators, "aggregators"); Preconditions.checkNotNull(logicalMetricNames, "logicalMetricNames"); Preconditions.checkArgument(aggregators.length == logicalMetricNames.length, "different length aggregators and" + - " logical names"); + " logical names"); --- End diff -- Avoid split on the string literal. Can the previous line be split after the comma? > Fix existing checkstyle violations in common module > --------------------------------------------------- > > Key: APEXCORE-268 > URL: https://issues.apache.org/jira/browse/APEXCORE-268 > Project: Apache Apex Core > Issue Type: Sub-task > Reporter: Chandni Singh > Assignee: Chandni Singh > -- This message was sent by Atlassian JIRA (v6.3.4#6332)