Return-Path: 
 <dev-return-5143-apmail-apex-dev-archive=apex.apache.org@apex.incubator.apache.org>
X-Original-To: apmail-apex-dev-archive@minotaur.apache.org
Delivered-To: apmail-apex-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id EDDE818705
	for <apmail-apex-dev-archive@minotaur.apache.org>;
 Tue, 26 Jan 2016 23:28:45 +0000 (UTC)
Received: (qmail 88605 invoked by uid 500); 26 Jan 2016 23:28:45 -0000
Delivered-To: apmail-apex-dev-archive@apex.apache.org
Received: (qmail 88537 invoked by uid 500); 26 Jan 2016 23:28:45 -0000
Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@apex.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@apex.incubator.apache.org>
List-Post: <mailto:dev@apex.incubator.apache.org>
List-Id: <dev.apex.incubator.apache.org>
Reply-To: dev@apex.incubator.apache.org
Delivered-To: mailing list dev@apex.incubator.apache.org
Received: (qmail 88524 invoked by uid 99); 26 Jan 2016 23:28:45 -0000
Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Jan 2016 23:28:45 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org)
 with ESMTP id 3AE38C253C
	for <dev@apex.apache.org>; Tue, 26 Jan 2016 23:28:45 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: 0.98
X-Spam-Level: 
X-Spam-Status: No, score=0.98 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01,
	RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001]
	autolearn=disabled
Received: from mx1-us-west.apache.org ([10.40.0.8])
	by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new,
 port 10024)
	with ESMTP id LjF2_if0vi30 for <dev@apex.apache.org>;
	Tue, 26 Jan 2016 23:28:35 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with
 SMTP id A04B820974
	for <dev@apex.incubator.apache.org>; Tue, 26 Jan 2016 23:28:35 +0000 (UTC)
Received: (qmail 88229 invoked by uid 99); 26 Jan 2016 23:28:35 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Jan 2016 23:28:35 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 6259ADFF96; Tue, 26 Jan 2016 23:28:35 +0000 (UTC)
From: siyuanh <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-178-incubator-apex-malhar@git.apache.org>
In-Reply-To: <git-pr-178-incubator-apex-malhar@git.apache.org>
Subject: [GitHub] incubator-apex-malhar pull request: APEXMALHAR-1984 refactor
 out o...
Content-Type: text/plain
Message-Id: <20160126232835.6259ADFF96@git1-us-west.apache.org>
Date: Tue, 26 Jan 2016 23:28:35 +0000 (UTC)

Github user siyuanh commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/178#discussion_r50919003
  
    --- Diff: contrib/src/main/java/com/datatorrent/contrib/couchbase/AbstractCouchBaseInputOperator.java ---
    @@ -149,15 +145,8 @@ public void partitioned(Map<Integer, Partition<AbstractCouchBaseInputOperator<T>
         int numPartitions = conf.getServers().size();
         List<String> list = conf.getServers();
         Collection<Partition<AbstractCouchBaseInputOperator<T>>> newPartitions = Lists.newArrayListWithExpectedSize(numPartitions);
    -    Kryo kryo = new Kryo();
         for (int i = 0; i < numPartitions; i++) {
    -      ByteArrayOutputStream bos = new ByteArrayOutputStream();
    -      Output output = new Output(bos);
    -      kryo.writeObject(output, this);
    -      output.close();
    -      Input lInput = new Input(bos.toByteArray());
    -      @SuppressWarnings("unchecked")
    -      AbstractCouchBaseInputOperator<T> oper = kryo.readObject(lInput, this.getClass());
    +      AbstractCouchBaseInputOperator<T> oper = PartitionerUtils.cloneOperatorByKryo(this);
    --- End diff --
    
    I don't want to leave the kryo creation code to the developer, it is error prone.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---