Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.incubator.apache.org
From: chinmaykolhatkar <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-208-incubator-apex-core@git.apache.org>
In-Reply-To: <git-pr-208-incubator-apex-core@git.apache.org>
Subject: [GitHub] incubator-apex-core pull request: APEXCORE-304 Added support
 for c...
Content-Type: text/plain
Message-Id: <20160121133936.BD42FDFF94@git1-us-west.apache.org>
Date: Thu, 21 Jan 2016 13:39:36 +0000 (UTC)

Github user chinmaykolhatkar commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/208#discussion_r50400951
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/StramLocalCluster.java ---
    @@ -308,6 +313,24 @@ public StramLocalCluster(LogicalPlan dag) throws IOException, ClassNotFoundExcep
         this.dnmgr = new StreamingContainerManager(dag);
         this.umbilical = new UmbilicalProtocolLocalImpl();
     
    +    Method addURL;
    +    URLClassLoader loader;
    +    try {
    +      loader = (URLClassLoader)ClassLoader.getSystemClassLoader();
    --- End diff --
    
    ClassLoader do not have addURl method, it's only present in  URLClassLoader.
    
    I get your point that system classloader might OR might not be URLClassLoader.
    
    Also, considering the operators will e deployed in seperate thread in local mode, I change the logic to add URL to Thread context classloader instead of system class loader.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---