Return-Path: 
 <dev-return-4574-apmail-apex-dev-archive=apex.apache.org@apex.incubator.apache.org>
X-Original-To: apmail-apex-dev-archive@minotaur.apache.org
Delivered-To: apmail-apex-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 041BE18BC4
	for <apmail-apex-dev-archive@minotaur.apache.org>;
 Wed, 13 Jan 2016 05:35:17 +0000 (UTC)
Received: (qmail 8572 invoked by uid 500); 13 Jan 2016 05:35:16 -0000
Delivered-To: apmail-apex-dev-archive@apex.apache.org
Received: (qmail 8511 invoked by uid 500); 13 Jan 2016 05:35:16 -0000
Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@apex.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@apex.incubator.apache.org>
List-Post: <mailto:dev@apex.incubator.apache.org>
List-Id: <dev.apex.incubator.apache.org>
Reply-To: dev@apex.incubator.apache.org
Delivered-To: mailing list dev@apex.incubator.apache.org
Received: (qmail 8490 invoked by uid 99); 13 Jan 2016 05:35:16 -0000
Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jan 2016 05:35:16 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org)
 with ESMTP id E1DF6C0E17
	for <dev@apex.apache.org>; Wed, 13 Jan 2016 05:35:15 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: 0.427
X-Spam-Level: 
X-Spam-Status: No, score=0.427 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01,
	RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.554, URIBL_BLOCKED=0.001]
	autolearn=disabled
Received: from mx1-eu-west.apache.org ([10.40.0.8])
	by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new,
 port 10024)
	with ESMTP id kBtVCU_J9MIr for <dev@apex.apache.org>;
	Wed, 13 Jan 2016 05:35:09 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with
 SMTP id 8AD9E31AB5
	for <dev@apex.incubator.apache.org>; Wed, 13 Jan 2016 05:35:08 +0000 (UTC)
Received: (qmail 8274 invoked by uid 99); 13 Jan 2016 05:35:07 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jan 2016 05:35:07 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id AB0D7E0615; Wed, 13 Jan 2016 05:35:07 +0000 (UTC)
From: tweise <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-168-incubator-apex-malhar@git.apache.org>
In-Reply-To: <git-pr-168-incubator-apex-malhar@git.apache.org>
Subject: [GitHub] incubator-apex-malhar pull request: Skip all the modules
 that shou...
Content-Type: text/plain
Message-Id: <20160113053507.AB0D7E0615@git1-us-west.apache.org>
Date: Wed, 13 Jan 2016 05:35:07 +0000 (UTC)

Github user tweise commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/168#discussion_r49553118
  
    --- Diff: samples/pom.xml ---
    @@ -34,6 +34,11 @@
     
       <name>Apache Apex Malhar (incubating) Samples</name>
     
    +  <properties>
    +    <semver.plugin.skip>true</semver.plugin.skip>
    --- End diff --
    
    No issue with the plugin management part. But I do not see the point of repeating the plugin like this:
    ```
          <plugin>
            <groupId>com.github.siom79.japicmp</groupId>
            <artifactId>japicmp-maven-plugin</artifactId>
          </plugin>
    ```
    in every module. Instead, I would prefer to see this in the malhar parent pom only and use the property that turns it off for those modules that should be exempt. That's how the deploy plugin is setup already.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---