Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.incubator.apache.org
From: vrozov <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-199-incubator-apex-core@git.apache.org>
In-Reply-To: <git-pr-199-incubator-apex-core@git.apache.org>
Subject: [GitHub] incubator-apex-core pull request: APEXCORE-268 #resolve
 #comment f...
Content-Type: text/plain
Message-Id: <20160108171209.483B8E0492@git1-us-west.apache.org>
Date: Fri,  8 Jan 2016 17:12:09 +0000 (UTC)

Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/199#discussion_r49212009
  
    --- Diff: common/src/main/java/com/datatorrent/common/util/SerializableObject.java ---
    @@ -58,37 +58,29 @@ public Object readResolve() throws ObjectStreamException
           Constructor<? extends SerializableObject> constructor = this.getClass().getConstructor(this.getClass());
           try {
             constructor.setAccessible(true);
    -      }
    -      catch (SecurityException ex) {
    +      } catch (SecurityException ex) {
             logger.warn("Accessing copy constructor {} failed.", constructor, ex);
           }
           try {
             return constructor.newInstance(this);
    -      }
    -      catch (InstantiationException ex) {
    +      } catch (InstantiationException ex) {
    --- End diff --
    
    Multi exception catch and usage of ReflectiveOperationException.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---