Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.incubator.apache.org
From: PramodSSImmaneni <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-187-incubator-apex-core@git.apache.org>
In-Reply-To: <git-pr-187-incubator-apex-core@git.apache.org>
Subject: [GitHub] incubator-apex-core pull request: Checkpoint notification to
 notif...
Content-Type: text/plain
Message-Id: <20160107022946.EE058DFDC7@git1-us-west.apache.org>
Date: Thu,  7 Jan 2016 02:29:46 +0000 (UTC)

Github user PramodSSImmaneni commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/187#discussion_r49036338
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/engine/Node.java ---
    @@ -485,6 +485,10 @@ protected void deactivateSinks()
     
       void checkpoint(long windowId)
       {
    +    if (operator instanceof Operator.CheckpointNotificationListener) {
    --- End diff --
    
    I see your point Thomas but as chinmay pointed out shouldn't both this and checkpointed callback not be called for stateless. Gaurav if you use this call in stateless operator to persist your operator state in your own way there is no inverse callback from the platform to recover that state.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---