Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.incubator.apache.org
From: gauravgopi123 <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-187-incubator-apex-core@git.apache.org>
In-Reply-To: <git-pr-187-incubator-apex-core@git.apache.org>
Subject: [GitHub] incubator-apex-core pull request: Checkpoint notification to
 notif...
Content-Type: text/plain
Message-Id: <20160106064747.6A66BE01C1@git1-us-west.apache.org>
Date: Wed,  6 Jan 2016 06:47:47 +0000 (UTC)

Github user gauravgopi123 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/187#discussion_r48931757
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/engine/Node.java ---
    @@ -485,6 +485,10 @@ protected void deactivateSinks()
     
       void checkpoint(long windowId)
       {
    +    if (operator instanceof Operator.CheckpointNotificationListener) {
    --- End diff --
    
    I think this call should be outside that loop. This call is mainly to manage your transient variables just before check pointing which stateless operator will have too


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---