Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.incubator.apache.org
From: chaithu14 <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-148-incubator-apex-malhar@git.apache.org>
In-Reply-To: <git-pr-148-incubator-apex-malhar@git.apache.org>
Subject: [GitHub] incubator-apex-malhar pull request: MLHR-1956 Added POJO
 Kafka Out...
Content-Type: text/plain
Message-Id: <20160106053227.F023AE0449@git1-us-west.apache.org>
Date: Wed,  6 Jan 2016 05:32:27 +0000 (UTC)

Github user chaithu14 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/148#discussion_r48929077
  
    --- Diff: contrib/src/main/java/com/datatorrent/contrib/kafka/POJOKafkaOutputOperator.java ---
    @@ -0,0 +1,266 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package com.datatorrent.contrib.kafka;
    +
    +import java.lang.reflect.Field;
    +import java.util.ArrayList;
    +import java.util.List;
    +import java.util.Properties;
    +
    +import javax.validation.constraints.Min;
    +import javax.validation.constraints.NotNull;
    +
    +import org.apache.commons.lang3.ClassUtils;
    +import org.apache.commons.lang3.StringUtils;
    +
    +import com.datatorrent.api.AutoMetric;
    +import com.datatorrent.api.Context;
    +import com.datatorrent.api.DefaultInputPort;
    +import com.datatorrent.lib.util.PojoUtils;
    +
    +import kafka.producer.KeyedMessage;
    +import kafka.producer.ProducerConfig;
    +
    +/**
    + * POJOKafkaOutputOperator extends from AbstractKafkaOutputOperator receives the POJO
    + * from upstream and converts to Kafka Messages and writes to kafka topic.&nbsp;
    + * <p>
    + * <br>
    + * Ports:<br>
    + * <b>Input</b>: Have only one input port<br>
    + * <b>Output</b>: No Output Port <br>
    + * <br>
    + * Properties:<br>
    + * <b>brokerList</b>: List of brokers in the form of Host1:Port1,Host2:Port2,Host3:port3,...<br>
    + * <b>keyField</b>: Specifies the field creates distribution of tuples to kafka partition. <br>
    + * <b>isBatchProcessing</b>: Specifies whether to write messages in batch or not. By default,
    + *                           the value is true <br>
    + * <b>batchSize</b>: Specifies the batch size.<br>
    + * <br>
    + * <br>
    + * </p>
    + *
    + * @displayName POJO Kafka Output
    + * @category Messaging
    + * @tags Output operator
    + *
    + */
    +public class POJOKafkaOutputOperator extends AbstractKafkaOutputOperator<Object,Object>
    +{
    +  @AutoMetric
    +  private long outputMessagesPerSec;
    +  @AutoMetric
    +  private long outputBytesPerSec;
    +  protected final Integer DEFAULT_BATCH_SIZE = 200;
    --- End diff --
    
    Yes. DEFAULT_BATCH_SIZE static value is not needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---