apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXMALHAR-1983) Support special chars in topics setting for new Kafka Input Operator
Date Sat, 30 Jan 2016 03:40:39 GMT

    [ https://issues.apache.org/jira/browse/APEXMALHAR-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15124692#comment-15124692
] 

ASF GitHub Bot commented on APEXMALHAR-1983:
--------------------------------------------

Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/176#discussion_r51339683
  
    --- Diff: kafka/src/main/java/org/apache/apex/malhar/kafka/AbstractKafkaInputOperator.java
---
    @@ -366,17 +374,19 @@ public String getClusters()
         return Joiner.on(';').join(clusters);
       }
     
    -  public void setTopics(String... topics)
    +  public void setTopics(String topics)
       {
    -    this.topics = topics;
    +    Topic.validate(topics.replace(" |,", "");
    +    this.topics = Iterables.toArray(Splitter.on(',').trimResults().omitEmptyStrings().split(topics),
String.class);
    --- End diff --
    
    It does not work. I guess, you mean `Topic.validate(topics.replaceAll(" |,", "");`


> Support special chars in topics setting for new Kafka Input Operator
> --------------------------------------------------------------------
>
>                 Key: APEXMALHAR-1983
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-1983
>             Project: Apache Apex Malhar
>          Issue Type: Improvement
>            Reporter: Siyuan Hua
>            Assignee: Siyuan Hua
>             Fix For: 3.4.0
>
>
> The setter method take string[] as parameter which confuse the json serializer which
character as separator. We should convert the string to string[] in setter method. Reserve
, as seperator



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message