apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXCORE-304) Ability to add jars to classpath in populateDAG
Date Tue, 19 Jan 2016 00:12:39 GMT

    [ https://issues.apache.org/jira/browse/APEXCORE-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15106011#comment-15106011
] 

ASF GitHub Bot commented on APEXCORE-304:
-----------------------------------------

Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/208#discussion_r50059334
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/StramClient.java ---
    @@ -455,6 +462,13 @@ public void startApplication() throws YarnException, IOException
           }
           String libJarsCsv = copyFromLocal(fs, appPath, localJarFiles.toArray(new String[]{}));
     
    +      // Now that the extra libs are copied, delete if it is required
    +      for (Map.Entry<String, Boolean> jars : extraResources.entrySet()) {
    +        if (jars.getValue()) {
    +          FileUtils.deleteQuietly(new File(jars.getKey()));
    --- End diff --
    
    Why quietly? If a user added a temporary jar and specified that it needs to be deleted,
should not warning be at minimum logged if the file can not be deleted for any reason?


> Ability to add jars to classpath in populateDAG
> -----------------------------------------------
>
>                 Key: APEXCORE-304
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-304
>             Project: Apache Apex Core
>          Issue Type: Improvement
>            Reporter: Chinmay Kolhatkar
>            Assignee: Chinmay Kolhatkar
>
> This will have following functionality:
> 1) In populateDAG one would be allowed to add given local jar path to classpath of the
application.
> 2) Optionally delete the given jar file after copying to HDFS is done.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message