apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXCORE-268) Fix existing checkstyle violations in common module
Date Fri, 08 Jan 2016 22:34:41 GMT

    [ https://issues.apache.org/jira/browse/APEXCORE-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090086#comment-15090086
] 

ASF GitHub Bot commented on APEXCORE-268:
-----------------------------------------

Github user tweise commented on the pull request:

    https://github.com/apache/incubator-apex-core/pull/199#issuecomment-170146555
  
    I think it is helpful to see the errors in the log because they will fail the build and
it is an extra step (albeit not a huge deal) for the submitter to run checkstyle:check -Dblablabla
locally (actually had added that to the contributor guidelines:).
    
    Whether "recommendations" should be warnings is perhaps a separate topic? 


> Fix existing checkstyle violations in common module
> ---------------------------------------------------
>
>                 Key: APEXCORE-268
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-268
>             Project: Apache Apex Core
>          Issue Type: Sub-task
>            Reporter: Chandni Singh
>            Assignee: Chandni Singh
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message