apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vrozov <...@git.apache.org>
Subject [GitHub] incubator-apex-malhar pull request: APEXMALHAR-1983 #resolve #comm...
Date Fri, 29 Jan 2016 02:48:14 GMT
Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/176#discussion_r51220369
  
    --- Diff: kafka/src/main/java/org/apache/apex/malhar/kafka/AbstractKafkaInputOperator.java
---
    @@ -366,17 +374,19 @@ public String getClusters()
         return Joiner.on(';').join(clusters);
       }
     
    -  public void setTopics(String... topics)
    +  public void setTopics(String topics)
       {
    -    this.topics = topics;
    +    Topic.validate(topics.replace(" |,", "");
    +    this.topics = Iterables.toArray(Splitter.on(',').trimResults().omitEmptyStrings().split(topics),
String.class);
    --- End diff --
    
    Was the intention of previous validate assumes that space and "|" are valid topic separators?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message