apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tweise <...@git.apache.org>
Subject [GitHub] incubator-apex-malhar pull request: Skip all the modules that shou...
Date Wed, 13 Jan 2016 05:35:07 GMT
Github user tweise commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/168#discussion_r49553118
  
    --- Diff: samples/pom.xml ---
    @@ -34,6 +34,11 @@
     
       <name>Apache Apex Malhar (incubating) Samples</name>
     
    +  <properties>
    +    <semver.plugin.skip>true</semver.plugin.skip>
    --- End diff --
    
    No issue with the plugin management part. But I do not see the point of repeating the
plugin like this:
    ```
          <plugin>
            <groupId>com.github.siom79.japicmp</groupId>
            <artifactId>japicmp-maven-plugin</artifactId>
          </plugin>
    ```
    in every module. Instead, I would prefer to see this in the malhar parent pom only and
use the property that turns it off for those modules that should be exempt. That's how the
deploy plugin is setup already.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message