apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From siyuanh <...@git.apache.org>
Subject [GitHub] incubator-apex-malhar pull request: APEXMALHAR-1970 #resolve #comm...
Date Tue, 12 Jan 2016 06:16:38 GMT
Github user siyuanh commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/167#discussion_r49418985
  
    --- Diff: kafka/src/test/java/org/apache/apex/malhar/kafka/KafkaInputOperatorTest.java
---
    @@ -48,26 +48,30 @@
     
       private int totalBrokers = 0;
     
    +  private String partition = null;
     
    -
    -  @Parameterized.Parameters(name = "multi-cluster: {0}, multi-partition: {1}")
    -  public static Collection<Boolean[]> testScenario()
    +  @Parameterized.Parameters(name = "multi-cluster: {0}, multi-partition: {1}, partition:
{2}")
    +  public static Collection<Object[]> testScenario()
       {
    -    return Arrays.asList(new Boolean[][]{{true, false}, // multi cluster with single
partition
    -      {true, true}, // multi cluster with multi partitions
    -      {false, true}, // single cluster with multi partitions
    -      {false, false}, // single cluster with single partitions
    +    return Arrays.asList(new Object[][]{{true, false, "one_to_one"},// multi cluster
with single partition
    --- End diff --
    
    Add different partition strategy settings


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message