apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vrozov <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEXCORE-268 #resolve #comment f...
Date Sat, 09 Jan 2016 22:33:22 GMT
Github user vrozov commented on the pull request:

    https://github.com/apache/incubator-apex-core/pull/199#issuecomment-170287936
  
    The problem is not that it is impossible to invoke maven with custom parameters and achieve
the desired result, IMO question and discussion is about default behavior. IMO, by default
errors and warnings for checkstyle should be printed the same way they are printed for compile.
This will give the most optimal default behavior that minimizes development effort to fix
errors and warnings.
    
    @chandnisingh my suggestion is not to completely disable line length check, but to disable
print out of those violations during default mvn invoke while outputting all other errors
and warnings. It will be good to make final decision whether or not we allow lines that exceed
120 characters, but this is a separate from this pull request discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message