apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vrozov <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEXCORE-268 #resolve #comment f...
Date Fri, 08 Jan 2016 16:35:02 GMT
Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/199#discussion_r49207712
  
    --- Diff: common/src/main/java/com/datatorrent/common/metric/MetricsAggregator.java ---
    @@ -129,13 +128,13 @@ public void addAggregators(@NotNull String metric, @NotNull SingleMetricAggregat
        *                           be used for the result of aggregators[i].
        */
       public void addAggregators(@NotNull String metric, @NotNull SingleMetricAggregator[]
aggregators,
    -                             @NotNull String[] logicalMetricNames)
    +      @NotNull String[] logicalMetricNames)
       {
         Preconditions.checkNotNull(metric, "metric");
         Preconditions.checkNotNull(aggregators, "aggregators");
         Preconditions.checkNotNull(logicalMetricNames, "logicalMetricNames");
         Preconditions.checkArgument(aggregators.length == logicalMetricNames.length, "different
length aggregators and" +
    -      " logical names");
    +        " logical names");
    --- End diff --
    
    Avoid split on the string literal. Can the previous line be split after the comma?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message