apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chandnisingh <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: Checkpoint notification to notif...
Date Thu, 07 Jan 2016 19:51:22 GMT
Github user chandnisingh commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/187#discussion_r49117385
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/engine/Node.java ---
    @@ -485,6 +485,10 @@ protected void deactivateSinks()
     
       void checkpoint(long windowId)
       {
    +    if (operator instanceof Operator.CheckpointNotificationListener) {
    --- End diff --
    
    I agree with @PramodSSImmaneni 
    By definition a Stateless operator is an operator which doesn't have a state to persist
which is irrespective of whether the operator developer wants the out-of-box state persistence
by platform or use any other custom way of persistence. But if the operator developer marks
it @Stateless that indicates that there isn't any state. 
    Being Stateless doesn't mean that operator will handle persisting state in a custom way.
For that we have a pluggable storage agent API.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message