apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chaithu14 <...@git.apache.org>
Subject [GitHub] incubator-apex-malhar pull request: MLHR-1720 Implemented Inmemory...
Date Thu, 07 Jan 2016 09:44:30 GMT
Github user chaithu14 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/113#discussion_r49056224
  
    --- Diff: library/src/main/java/com/datatorrent/lib/join/JoinStore.java ---
    @@ -0,0 +1,91 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package com.datatorrent.lib.join;
    +
    +import java.util.List;
    +
    +import org.apache.hadoop.classification.InterfaceStability;
    +
    +import com.datatorrent.api.Component;
    +
    +/**
    + * <p>
    + * Interface of store for join operation.
    + * </p>
    + */
    +@InterfaceStability.Unstable
    +public interface JoinStore extends Component
    +{
    +  /**
    +   * Generate the store
    +   */
    +
    +  /**
    +   * Perform the committed operation
    +   * @param windowId
    +   */
    +  void committed(long windowId);
    +
    +  /**
    +   * Save the state of store
    +   * @param windowId
    +   */
    +  void checkpointed(long windowId);
    +
    +  /**
    +   * Add the operations, any needed for store before begin the window
    +   * @param windowId
    +   */
    +  void beginWindow(long windowId);
    +
    +  /**
    +   *
    +   */
    +  void endWindow();
    +
    +  /**
    +   * Get the key from the given tuple and with that key, get the tuples which satisfies
the join constraint
    +   * from the store.
    +   *
    +   * @param tuple Given tuple
    +   * @return the valid tuples which statisfies the join constraint
    +   */
    +  List<?> getValidTuples(Object tuple);
    +
    +  /**
    +   * Insert the given tuple
    +   *
    +   * @param tuple Given tuple
    +   */
    +  Boolean put(Object tuple);
    --- End diff --
    
    Don't remembered, why Boolean object is used. Return type should be a boolean.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message