apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gauravgopi123 <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: Checkpoint notification to notif...
Date Wed, 06 Jan 2016 22:08:40 GMT
Github user gauravgopi123 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/187#discussion_r49016695
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/engine/Node.java ---
    @@ -485,6 +485,10 @@ protected void deactivateSinks()
     
       void checkpoint(long windowId)
       {
    +    if (operator instanceof Operator.CheckpointNotificationListener) {
    --- End diff --
    
    I think this call should be made irrespective of whether the operator is stateless or
not. Here is the case I am thinking of, If I want to serialize the operator state in my own
way I should be able to do in call. I can mark all my properties transient and use this call
to serialize my state. I can do using storage agent too but this could be easier and faster
way.. 
    
    Just a thought


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message