apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gauravgopi123 <...@git.apache.org>
Subject [GitHub] incubator-apex-malhar pull request: Mlhr 1942.geode
Date Tue, 05 Jan 2016 18:41:49 GMT
Github user gauravgopi123 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/131#discussion_r48879266
  
    --- Diff: contrib/src/main/java/com/datatorrent/contrib/geode/GeodeStore.java ---
    @@ -0,0 +1,308 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package com.datatorrent.contrib.geode;
    +
    +import java.io.IOException;
    +import java.io.Serializable;
    +import java.util.ArrayList;
    +import java.util.List;
    +import java.util.Map;
    +
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import com.gemstone.gemfire.cache.CacheClosedException;
    +import com.gemstone.gemfire.cache.CacheWriterException;
    +import com.gemstone.gemfire.cache.EntryNotFoundException;
    +import com.gemstone.gemfire.cache.Region;
    +import com.gemstone.gemfire.cache.TimeoutException;
    +import com.gemstone.gemfire.cache.client.ClientCache;
    +import com.gemstone.gemfire.cache.client.ClientCacheFactory;
    +import com.gemstone.gemfire.cache.client.ClientRegionShortcut;
    +import com.gemstone.gemfire.cache.query.FunctionDomainException;
    +import com.gemstone.gemfire.cache.query.NameResolutionException;
    +import com.gemstone.gemfire.cache.query.QueryInvocationTargetException;
    +import com.gemstone.gemfire.cache.query.SelectResults;
    +import com.gemstone.gemfire.cache.query.TypeMismatchException;
    +
    +import com.datatorrent.lib.db.KeyValueStore;
    +
    +/**
    + * Provides the implementation of a Geode store.
    + *
    + * 
    + */
    +public class GeodeStore implements KeyValueStore, Serializable
    +{
    +  /**
    +   * 
    +   */
    +  private static final long serialVersionUID = -5076452548893319967L;
    +  private static final Logger LOG = LoggerFactory.getLogger(GeodeStore.class);
    +  private transient ClientCache clientCache = null;
    +  private transient Region<Object, Object> region = null;
    +  private String locatorHost;
    +  private int locatorPort;
    +  private String regionName;
    +
    +  private ClientCache initClient()
    --- End diff --
    
    I see as getting used only at one place `getRegion` and it has only one statement. Why
another function?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message