apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gauravgopi123 <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEXCORE-60 Iteration support in...
Date Mon, 04 Jan 2016 20:35:22 GMT
Github user gauravgopi123 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/185#discussion_r48777786
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/engine/GenericNode.java ---
    @@ -343,12 +389,15 @@ else if (!doCheckpoint) {
                      * we will receive tuples which are equal to the number of input streams.
                      */
                     activePort.remove();
    -                buffers.remove();
    +                if (isInputPortConnectedToDelayOperator(activePortEntry.getKey())) {
    +                  break; // breaking out of the switch/case
    +                }
     
    +                buffers.remove();
    --- End diff --
    
    Should this not be before `if` condition above?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message