apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DT-Priyanka <...@git.apache.org>
Subject [GitHub] incubator-apex-malhar pull request: [Review only] MLHR 1957 hbase ...
Date Mon, 04 Jan 2016 10:53:25 GMT
Github user DT-Priyanka commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/155#discussion_r48720413
  
    --- Diff: contrib/src/main/java/com/datatorrent/contrib/hbase/HBaseFieldValueGenerator.java
---
    @@ -0,0 +1,46 @@
    +package com.datatorrent.contrib.hbase;
    +
    +import java.util.List;
    +
    +import com.datatorrent.lib.util.FieldValueGenerator;
    +import com.datatorrent.lib.util.PojoUtils;
    +
    +/**
    + * A {@link FieldValueGenerator} implementation for {@link HBaseFieldInfo}
    + */
    +public class HBaseFieldValueGenerator extends FieldValueGenerator<HBaseFieldInfo>
    +{
    +
    +  public static HBaseFieldValueGenerator getHBaseFieldValueGenerator(final Class<?>
clazz, List<HBaseFieldInfo>
    --- End diff --
    
    why don't we override "getFieldValueGenerator()"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message