apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chinmaykolhatkar <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: Checkpoint notification to notif...
Date Sun, 03 Jan 2016 16:29:53 GMT
Github user chinmaykolhatkar commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/187#discussion_r48694586
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/engine/Node.java ---
    @@ -485,6 +485,10 @@ protected void deactivateSinks()
     
       void checkpoint(long windowId)
       {
    +    if (operator instanceof Operator.CheckpointNotificationListener) {
    +      ((Operator.CheckpointNotificationListener)operator).beforeCheckpoint(windowId);
    --- End diff --
    
    Should this be caught for Throwable?
    In case the beforeCheckpoint throws exception, the states which are meant to be saved
won't be.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message