Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.incubator.apache.org
Date: Wed, 30 Dec 2015 21:32:49 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@apex.incubator.apache.org
Message-ID: <JIRA.12919440.1448313210000.30679.1451511169672@Atlassian.JIRA>
In-Reply-To: <JIRA.12919440.1448313210000@Atlassian.JIRA>
References: <JIRA.12919440.1448313210000@Atlassian.JIRA>
 <JIRA.12919440.1448313210000@arcas>
Subject: [jira] [Commented] (APEXCORE-276) Make App Data Push transport
 pluggable and configurable
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/APEXCORE-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075419#comment-15075419 ] 

ASF GitHub Bot commented on APEXCORE-276:
-----------------------------------------

Github user davidyan74 commented on the pull request:

    https://github.com/apache/incubator-apex-core/pull/193#issuecomment-168076912
  
    I just implemented what Thomas suggested, but I kept the METRICS_TRANSPORT attribute since it's not currently widely used but I can change it if people have concerns.


> Make App Data Push transport pluggable and configurable
> -------------------------------------------------------
>
>                 Key: APEXCORE-276
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-276
>             Project: Apache Apex Core
>          Issue Type: New Feature
>            Reporter: David Yan
>            Assignee: David Yan
>
> Currently it's not possible without changing the code to have your own transport.
> Code from AppDataPushAgent.java:
> {code}  
>   public void init()
>   {
>     String appDataPushTransport = dnmgr.getLogicalPlan().getValue(DAGContext.METRICS_TRANSPORT);
>     if (appDataPushTransport.startsWith(APP_DATA_PUSH_TRANSPORT_BUILTIN_VALUE + ":")) {
>       String topic = appDataPushTransport.substring(APP_DATA_PUSH_TRANSPORT_BUILTIN_VALUE.length() + 1);
>       appDataPusher = new WebsocketAppDataPusher(dnmgr.getWsClient(), topic);
>       LOG.info("App Data Push Transport set up for {}", appDataPushTransport);
>     } else {
>       // TBD add kakfa
>       LOG.error("App Data Push Transport not recognized: {}", appDataPushTransport);
>     }
>   }
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)