Return-Path: 
 <dev-return-3838-apmail-apex-dev-archive=apex.apache.org@apex.incubator.apache.org>
X-Original-To: apmail-apex-dev-archive@minotaur.apache.org
Delivered-To: apmail-apex-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 92F2518104
	for <apmail-apex-dev-archive@minotaur.apache.org>;
 Wed, 30 Dec 2015 17:48:00 +0000 (UTC)
Received: (qmail 70505 invoked by uid 500); 30 Dec 2015 17:48:00 -0000
Delivered-To: apmail-apex-dev-archive@apex.apache.org
Received: (qmail 70440 invoked by uid 500); 30 Dec 2015 17:48:00 -0000
Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@apex.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@apex.incubator.apache.org>
List-Post: <mailto:dev@apex.incubator.apache.org>
List-Id: <dev.apex.incubator.apache.org>
Reply-To: dev@apex.incubator.apache.org
Delivered-To: mailing list dev@apex.incubator.apache.org
Received: (qmail 70427 invoked by uid 99); 30 Dec 2015 17:48:00 -0000
Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Dec 2015 17:48:00 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org)
 with ESMTP id D5F1C1804BE
	for <dev@apex.apache.org>; Wed, 30 Dec 2015 17:47:59 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: 1.227
X-Spam-Level: *
X-Spam-Status: No, score=1.227 tagged_above=-999 required=6.31
	tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1,
	RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	RP_MATCHES_RCVD=-0.554, URIBL_BLOCKED=0.001] autolearn=disabled
Received: from mx1-eu-west.apache.org ([10.40.0.8])
	by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new,
 port 10024)
	with ESMTP id Ju3qUx-eI6MO for <dev@apex.apache.org>;
	Wed, 30 Dec 2015 17:47:51 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with
 SMTP id 6A923201E9
	for <dev@apex.incubator.apache.org>; Wed, 30 Dec 2015 17:47:50 +0000 (UTC)
Received: (qmail 70158 invoked by uid 99); 30 Dec 2015 17:47:49 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Dec 2015 17:47:49 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 8AFCA2C044E
	for <dev@apex.incubator.apache.org>; Wed, 30 Dec 2015 17:47:49 +0000 (UTC)
Date: Wed, 30 Dec 2015 17:47:49 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@apex.incubator.apache.org
Message-ID: <JIRA.12919440.1448313210000.29746.1451497669565@Atlassian.JIRA>
In-Reply-To: <JIRA.12919440.1448313210000@Atlassian.JIRA>
References: <JIRA.12919440.1448313210000@Atlassian.JIRA>
 <JIRA.12919440.1448313210000@arcas>
Subject: [jira] [Commented] (APEXCORE-276) Make App Data Push transport
 pluggable and configurable
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/APEXCORE-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075253#comment-15075253 ] 

ASF GitHub Bot commented on APEXCORE-276:
-----------------------------------------

Github user davidyan74 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/193#discussion_r48619057
  
    --- Diff: api/src/main/java/com/datatorrent/api/Context.java ---
    @@ -335,10 +335,16 @@
         Attribute<String> APPLICATION_DATA_LINK = new Attribute<String>(new String2String());
         /**
          * Transport to push the stats and the metrics, "builtin:{topic}" if STRAM should push the data directly
    -     * using websocket with the given topic
    +     * using websocket with the given topic.
    +     * If using a custom transport, please use Object2String codec to specify the transport object.  The object must
    +     * be from a class that implements the AutoMetric.Transport interface
          */
         Attribute<String> METRICS_TRANSPORT = new Attribute<String>(new String2String());
    --- End diff --
    
    @chandnisingh this is for backward compatibility for the value "builtin:{topic}"


> Make App Data Push transport pluggable and configurable
> -------------------------------------------------------
>
>                 Key: APEXCORE-276
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-276
>             Project: Apache Apex Core
>          Issue Type: New Feature
>            Reporter: David Yan
>            Assignee: David Yan
>
> Currently it's not possible without changing the code to have your own transport.
> Code from AppDataPushAgent.java:
> {code}  
>   public void init()
>   {
>     String appDataPushTransport = dnmgr.getLogicalPlan().getValue(DAGContext.METRICS_TRANSPORT);
>     if (appDataPushTransport.startsWith(APP_DATA_PUSH_TRANSPORT_BUILTIN_VALUE + ":")) {
>       String topic = appDataPushTransport.substring(APP_DATA_PUSH_TRANSPORT_BUILTIN_VALUE.length() + 1);
>       appDataPusher = new WebsocketAppDataPusher(dnmgr.getWsClient(), topic);
>       LOG.info("App Data Push Transport set up for {}", appDataPushTransport);
>     } else {
>       // TBD add kakfa
>       LOG.error("App Data Push Transport not recognized: {}", appDataPushTransport);
>     }
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)