Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.incubator.apache.org
From: tweise <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-152-incubator-apex-malhar@git.apache.org>
In-Reply-To: <git-pr-152-incubator-apex-malhar@git.apache.org>
Subject: [GitHub] incubator-apex-malhar pull request: Clean corrent temp
 directories...
Content-Type: text/plain
Message-Id: <20151230215153.C734EE045F@git1-us-west.apache.org>
Date: Wed, 30 Dec 2015 21:51:53 +0000 (UTC)

Github user tweise commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/152#discussion_r48634129
  
    --- Diff: contrib/src/test/java/com/datatorrent/contrib/kafka/KafkaInputOperatorTest.java ---
    @@ -234,7 +236,20 @@ public void testKafkaInputOperator_Invalid() throws Exception
       public void afterTest()
       {
         tupleCount.set(0);
    --- End diff --
    
    Why is this done after the test? It should done before as you cannot guarantee how previous runs were terminated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---