Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.incubator.apache.org
From: shubham-pathak22 <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-131-incubator-apex-malhar@git.apache.org>
In-Reply-To: <git-pr-131-incubator-apex-malhar@git.apache.org>
Subject: [GitHub] incubator-apex-malhar pull request: Mlhr 1942.geode
Content-Type: text/plain
Message-Id: <20151228111408.C2163DFF93@git1-us-west.apache.org>
Date: Mon, 28 Dec 2015 11:14:08 +0000 (UTC)

Github user shubham-pathak22 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/131#discussion_r48474276
  
    --- Diff: contrib/src/main/java/com/datatorrent/contrib/geode/GeodeStore.java ---
    @@ -0,0 +1,308 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package com.datatorrent.contrib.geode;
    +
    +import java.io.IOException;
    +import java.io.Serializable;
    +import java.util.ArrayList;
    +import java.util.List;
    +import java.util.Map;
    +
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import com.gemstone.gemfire.cache.CacheClosedException;
    +import com.gemstone.gemfire.cache.CacheWriterException;
    +import com.gemstone.gemfire.cache.EntryNotFoundException;
    +import com.gemstone.gemfire.cache.Region;
    +import com.gemstone.gemfire.cache.TimeoutException;
    +import com.gemstone.gemfire.cache.client.ClientCache;
    +import com.gemstone.gemfire.cache.client.ClientCacheFactory;
    +import com.gemstone.gemfire.cache.client.ClientRegionShortcut;
    +import com.gemstone.gemfire.cache.query.FunctionDomainException;
    +import com.gemstone.gemfire.cache.query.NameResolutionException;
    +import com.gemstone.gemfire.cache.query.QueryInvocationTargetException;
    +import com.gemstone.gemfire.cache.query.SelectResults;
    +import com.gemstone.gemfire.cache.query.TypeMismatchException;
    +
    +import com.datatorrent.lib.db.KeyValueStore;
    +
    +/**
    + * Provides the implementation of a Geode store.
    + *
    + * 
    + */
    +public class GeodeStore implements KeyValueStore, Serializable
    +{
    +  /**
    +   * 
    +   */
    +  private static final long serialVersionUID = -5076452548893319967L;
    +  private static final Logger LOG = LoggerFactory.getLogger(GeodeStore.class);
    +  private transient ClientCache clientCache = null;
    +  private transient Region<Object, Object> region = null;
    +  private String locatorHost;
    +  private int locatorPort;
    +  private String regionName;
    +
    +  private ClientCache initClient()
    +  {
    +    try {
    +      clientCache = new ClientCacheFactory().addPoolLocator(getLocatorHost(), getLocatorPort()).create();
    +    } catch (CacheClosedException ex) {
    +      LOG.info("error initiating client ", ex);
    +    }
    +
    +    return clientCache;
    +  }
    +
    +  /**
    +   * @return the regionName
    +   */
    +  public String getRegionName()
    +  {
    +    return regionName;
    +  }
    +
    +  /**
    +   * @param regionName
    +   *          the regionName to set
    +   */
    +  public void setRegionName(String regionName)
    +  {
    +    this.regionName = regionName;
    +  }
    +
    +  /**
    +   * @return the clientCache
    +   */
    +  public ClientCache getClientCache()
    +  {
    +    return clientCache;
    +  }
    +
    +  /**
    +   * @param clientCache
    +   *          the clientCache to set
    +   */
    +  public void setClientCache(ClientCache clientCache)
    +  {
    +    this.clientCache = clientCache;
    +  }
    +
    +  /**
    +   * @return the locatorPort
    +   */
    +  public int getLocatorPort()
    +  {
    +    return locatorPort;
    +  }
    +
    +  /**
    +   * @param locatorPort
    +   *          the locatorPort to set
    +   */
    +  public void setLocatorPort(int locatorPort)
    +  {
    +    this.locatorPort = locatorPort;
    +  }
    +
    +  /**
    +   * @return the locatorHost
    +   */
    +  public String getLocatorHost()
    +  {
    +    return locatorHost;
    +  }
    +
    +  /**
    +   * @param locatorHost
    +   *          the locatorHost to set
    +   */
    +  public void setLocatorHost(String locatorHost)
    +  {
    +    this.locatorHost = locatorHost;
    +  }
    +
    +  /**
    +   * @return the region
    +   * @throws IOException
    +   */
    +  public Region<Object, Object> getRegion() throws IOException
    +  {
    +    // return region;
    +    if (clientCache == null && clientCache.isClosed()) {
    +      initClient();
    +    }
    +
    +    if (region == null) {
    +      region = clientCache.getRegion(regionName);
    +      if (region == null) {
    +        region = clientCache.<Object, Object> createClientRegionFactory(ClientRegionShortcut.PROXY).create(regionName);
    +      }
    +    }
    +
    +    return region;
    +  }
    +
    +  /**
    +   * @param region
    +   *          the region to set
    +   */
    +  public void setRegion(Region<Object, Object> region) throws IOException
    +  {
    +    this.region = region;
    +  }
    +
    +  @Override
    +  public void connect() throws IOException
    +  {
    +    try {
    +      clientCache = new ClientCacheFactory().addPoolLocator(getLocatorHost(), getLocatorPort()).create();
    +    } catch (CacheClosedException ex) {
    +      LOG.info("error initiating client ", ex);
    +    }
    +
    +    region = clientCache.getRegion(getRegionName());
    +
    --- End diff --
    
    This can throw NPE if CacheClosedException is thrown during initialization of clientCache


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---