Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.incubator.apache.org
From: chaithu14 <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-136-incubator-apex-malhar@git.apache.org>
In-Reply-To: <git-pr-136-incubator-apex-malhar@git.apache.org>
Subject: [GitHub] incubator-apex-malhar pull request: *For Review Only* Apex
 247 - I...
Content-Type: text/plain
Message-Id: <20151222122552.5326BDFF10@git1-us-west.apache.org>
Date: Tue, 22 Dec 2015 12:25:52 +0000 (UTC)

Github user chaithu14 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/136#discussion_r48248570
  
    --- Diff: library/src/main/java/com/datatorrent/lib/iteration/DefaultDelayOperator.java ---
    @@ -0,0 +1,151 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +package com.datatorrent.lib.iteration;
    +
    +import java.io.IOException;
    +import java.util.ArrayList;
    +
    +import com.datatorrent.api.Context;
    +import com.datatorrent.api.DefaultInputPort;
    +import com.datatorrent.api.DefaultOutputPort;
    +import com.datatorrent.api.Operator;
    +import com.datatorrent.lib.util.WindowDataManager;
    +import com.datatorrent.netlet.util.DTThrowable;
    +
    +public class DefaultDelayOperator<T> implements Operator.DelayOperator, Operator.CheckpointListener
    +{
    +  public WindowDataManager getWindowDataManager()
    +  {
    +    return windowDataManager;
    +  }
    +
    +  public void setWindowDataManager(WindowDataManager windowDataManager)
    +  {
    +    this.windowDataManager = windowDataManager;
    +  }
    +
    +  private WindowDataManager windowDataManager;
    +  private transient long currentWindowId;
    --- End diff --
    
    Can you make the variables to protected, which of the variables doesn't have setter and getter ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---