Return-Path: 
 <dev-return-2703-apmail-apex-dev-archive=apex.apache.org@apex.incubator.apache.org>
X-Original-To: apmail-apex-dev-archive@minotaur.apache.org
Delivered-To: apmail-apex-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id AF1BF10656
	for <apmail-apex-dev-archive@minotaur.apache.org>;
 Fri,  4 Dec 2015 08:27:27 +0000 (UTC)
Received: (qmail 61075 invoked by uid 500); 4 Dec 2015 08:27:27 -0000
Delivered-To: apmail-apex-dev-archive@apex.apache.org
Received: (qmail 61006 invoked by uid 500); 4 Dec 2015 08:27:27 -0000
Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@apex.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@apex.incubator.apache.org>
List-Post: <mailto:dev@apex.incubator.apache.org>
List-Id: <dev.apex.incubator.apache.org>
Reply-To: dev@apex.incubator.apache.org
Delivered-To: mailing list dev@apex.incubator.apache.org
Received: (qmail 60995 invoked by uid 99); 4 Dec 2015 08:27:27 -0000
Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Dec 2015 08:27:27 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org)
 with ESMTP id B4600180A34
	for <dev@apex.apache.org>; Fri,  4 Dec 2015 08:27:26 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -0.553
X-Spam-Level: 
X-Spam-Status: No, score=-0.553 tagged_above=-999 required=6.31
	tests=[RP_MATCHES_RCVD=-0.554, URIBL_BLOCKED=0.001] autolearn=disabled
Received: from mx1-us-west.apache.org ([10.40.0.8])
	by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new,
 port 10024)
	with ESMTP id U4yPO1JkCtZR for <dev@apex.apache.org>;
	Fri,  4 Dec 2015 08:27:15 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with
 SMTP id 738E820221
	for <dev@apex.incubator.apache.org>; Fri,  4 Dec 2015 08:27:15 +0000 (UTC)
Received: (qmail 60951 invoked by uid 99); 4 Dec 2015 08:27:15 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Dec 2015 08:27:15 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 241EFDFE04; Fri,  4 Dec 2015 08:27:15 +0000 (UTC)
From: tushargosavi <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-148-incubator-apex-core@git.apache.org>
In-Reply-To: <git-pr-148-incubator-apex-core@git.apache.org>
Subject: [GitHub] incubator-apex-core pull request: APEX-103: Add module and
 dag int...
Content-Type: text/plain
Message-Id: <20151204082715.241EFDFE04@git1-us-west.apache.org>
Date: Fri,  4 Dec 2015 08:27:15 +0000 (UTC)

Github user tushargosavi commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/148#discussion_r46658699
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
    @@ -1079,16 +1109,179 @@ public int hashCode()
         return operator;
       }
     
    -  @Override
    -  public <T extends Module> T addModule(String name, Class<T> moduleClass)
    +  public final class ModuleMeta implements DAG.ModuleMeta, Serializable
       {
    -    throw new UnsupportedOperationException("Modules are not supported");
    +    private final LinkedHashMap<InputPortMeta, StreamMeta> inputStreams = new LinkedHashMap<InputPortMeta, StreamMeta>();
    +    private final LinkedHashMap<OutputPortMeta, StreamMeta> outputStreams = new LinkedHashMap<OutputPortMeta, StreamMeta>();
    +    private final Attribute.AttributeMap attributes;
    +    @SuppressWarnings("unused")
    +    private final int id;
    +    @NotNull
    +    private String name;
    +    private transient Integer nindex; // for cycle detection
    +    private transient Integer lowlink; // for cycle detection
    +    private transient Module module;
    +    private String parentModuleName;
    +    private LogicalPlan dag = null;
    +
    +    public ModuleMeta(String name, Module module)
    +    {
    +      this(name, module, new DefaultAttributeMap());
    +    }
    +
    +    public ModuleMeta(String name, Module module, DefaultAttributeMap attributeMap)
    +    {
    +      LOG.debug("Initializing {} as {}", name, module.getClass().getName());
    +      this.name = name;
    +      this.module = module;
    +      this.id = logicalOperatorSequencer.decrementAndGet();
    +      this.attributes = attributeMap;
    +      this.dag = new LogicalPlan();
    +    }
    +
    +    @Override
    +    public String getName()
    +    {
    +      return name;
    +    }
    +
    +    @Override
    +    public Module getModule()
    +    {
    +      return module;
    +    }
    +
    +    @Override
    +    public DAG.InputPortMeta getMeta(InputPort<?> port)
    +    {
    +      return null;
    +    }
    +
    +    @Override
    +    public DAG.OutputPortMeta getMeta(OutputPort<?> port)
    +    {
    +      return null;
    +    }
    +
    +    @Override
    +    public Attribute.AttributeMap getAttributes()
    +    {
    +      return null;
    --- End diff --
    
    fixed this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---