Return-Path: 
 <dev-return-2648-apmail-apex-dev-archive=apex.apache.org@apex.incubator.apache.org>
X-Original-To: apmail-apex-dev-archive@minotaur.apache.org
Delivered-To: apmail-apex-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 9E7381874A
	for <apmail-apex-dev-archive@minotaur.apache.org>;
 Thu,  3 Dec 2015 06:26:14 +0000 (UTC)
Received: (qmail 30918 invoked by uid 500); 3 Dec 2015 06:26:14 -0000
Delivered-To: apmail-apex-dev-archive@apex.apache.org
Received: (qmail 30852 invoked by uid 500); 3 Dec 2015 06:26:14 -0000
Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@apex.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@apex.incubator.apache.org>
List-Post: <mailto:dev@apex.incubator.apache.org>
List-Id: <dev.apex.incubator.apache.org>
Reply-To: dev@apex.incubator.apache.org
Delivered-To: mailing list dev@apex.incubator.apache.org
Received: (qmail 30841 invoked by uid 99); 3 Dec 2015 06:26:14 -0000
Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Dec 2015 06:26:14 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org)
 with ESMTP id CF79CC44A4
	for <dev@apex.apache.org>; Thu,  3 Dec 2015 06:26:13 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: 0.971
X-Spam-Level: 
X-Spam-Status: No, score=0.971 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01,
	RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001]
	autolearn=disabled
Received: from mx1-eu-west.apache.org ([10.40.0.8])
	by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new,
 port 10024)
	with ESMTP id HVGIHbVyb0mQ for <dev@apex.apache.org>;
	Thu,  3 Dec 2015 06:26:07 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with
 SMTP id E839A20F5E
	for <dev@apex.incubator.apache.org>; Thu,  3 Dec 2015 06:26:05 +0000 (UTC)
Received: (qmail 30724 invoked by uid 99); 3 Dec 2015 06:26:05 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Dec 2015 06:26:05 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id F0185E67E8; Thu,  3 Dec 2015 06:26:04 +0000 (UTC)
From: gauravgopi123 <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-148-incubator-apex-core@git.apache.org>
In-Reply-To: <git-pr-148-incubator-apex-core@git.apache.org>
Subject: [GitHub] incubator-apex-core pull request: APEX-103: Add module and
 dag int...
Content-Type: text/plain
Message-Id: <20151203062604.F0185E67E8@git1-us-west.apache.org>
Date: Thu,  3 Dec 2015 06:26:04 +0000 (UTC)

Github user gauravgopi123 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/148#discussion_r46516446
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
    @@ -1079,16 +1109,179 @@ public int hashCode()
         return operator;
       }
     
    -  @Override
    -  public <T extends Module> T addModule(String name, Class<T> moduleClass)
    +  public final class ModuleMeta implements DAG.ModuleMeta, Serializable
       {
    -    throw new UnsupportedOperationException("Modules are not supported");
    +    private final LinkedHashMap<InputPortMeta, StreamMeta> inputStreams = new LinkedHashMap<InputPortMeta, StreamMeta>();
    +    private final LinkedHashMap<OutputPortMeta, StreamMeta> outputStreams = new LinkedHashMap<OutputPortMeta, StreamMeta>();
    +    private final Attribute.AttributeMap attributes;
    +    @SuppressWarnings("unused")
    --- End diff --
    
    Why is this required?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---