apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXCORE-276) Make App Data Push transport pluggable and configurable
Date Wed, 30 Dec 2015 18:46:49 GMT

    [ https://issues.apache.org/jira/browse/APEXCORE-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075302#comment-15075302
] 

ASF GitHub Bot commented on APEXCORE-276:
-----------------------------------------

Github user tweise commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/193#discussion_r48622829
  
    --- Diff: api/src/main/java/com/datatorrent/api/Context.java ---
    @@ -335,10 +335,16 @@
         Attribute<String> APPLICATION_DATA_LINK = new Attribute<String>(new String2String());
         /**
          * Transport to push the stats and the metrics, "builtin:{topic}" if STRAM should
push the data directly
    -     * using websocket with the given topic
    +     * using websocket with the given topic.
    +     * If using a custom transport, please use Object2String codec to specify the transport
object.  The object must
    +     * be from a class that implements the AutoMetric.Transport interface
          */
         Attribute<String> METRICS_TRANSPORT = new Attribute<String>(new String2String());
         /**
    +     * The interval in milliseconds to resend metrics schema. Default value is 10,000
(10 seconds)
    +     */
    +    Attribute<Long> METRICS_SCHEMA_RESEND_INTERVAL = new Attribute<Long>(10000L);
    --- End diff --
    
    Shouldn't the resend interval be part of the transport as the need to do that is driven
by the properties of the transport, i.e. need to resend if messages could be lost?


> Make App Data Push transport pluggable and configurable
> -------------------------------------------------------
>
>                 Key: APEXCORE-276
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-276
>             Project: Apache Apex Core
>          Issue Type: New Feature
>            Reporter: David Yan
>            Assignee: David Yan
>
> Currently it's not possible without changing the code to have your own transport.
> Code from AppDataPushAgent.java:
> {code}  
>   public void init()
>   {
>     String appDataPushTransport = dnmgr.getLogicalPlan().getValue(DAGContext.METRICS_TRANSPORT);
>     if (appDataPushTransport.startsWith(APP_DATA_PUSH_TRANSPORT_BUILTIN_VALUE + ":"))
{
>       String topic = appDataPushTransport.substring(APP_DATA_PUSH_TRANSPORT_BUILTIN_VALUE.length()
+ 1);
>       appDataPusher = new WebsocketAppDataPusher(dnmgr.getWsClient(), topic);
>       LOG.info("App Data Push Transport set up for {}", appDataPushTransport);
>     } else {
>       // TBD add kakfa
>       LOG.error("App Data Push Transport not recognized: {}", appDataPushTransport);
>     }
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message