apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXCORE-272) Attributes added to operator inside Module is not preserved.
Date Thu, 31 Dec 2015 06:32:49 GMT

    [ https://issues.apache.org/jira/browse/APEXCORE-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075775#comment-15075775
] 

ASF GitHub Bot commented on APEXCORE-272:
-----------------------------------------

Github user tushargosavi commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/191#discussion_r48647935
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
    @@ -1374,7 +1425,8 @@ private void addDAGToCurrentDAG(ModuleMeta moduleMeta)
           InputPort[] inputPorts = ports.toArray(new InputPort[]{});
     
           name = subDAGName + MODULE_NAMESPACE_SEPARATOR + streamMeta.getName();
    -      this.addStream(name, sourceMeta.getPortObject(), inputPorts);
    +      StreamMeta streamMetaNew = this.addStream(name, sourceMeta.getPortObject(), inputPorts);
    +      streamMetaNew.copyFrom(streamMeta);
    --- End diff --
    
    Done ..


> Attributes added to operator inside Module is not preserved.
> ------------------------------------------------------------
>
>                 Key: APEXCORE-272
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-272
>             Project: Apache Apex Core
>          Issue Type: Bug
>            Reporter: Tushar Gosavi
>            Assignee: Tushar Gosavi
>
> Attributes added to operator within a Module is not preserved.
> for example
> {code}
> class M implements Module {
>   public void populateDAG(DAG dag, Configuration conf) {
>      DummyOperator o1 = dag.addOperator("O1", new DummyOperator());
>      o1.setOperatorProp(level1ModuleProp);
>      dag.getMeta(o1).getAttributes().put(Context.OperatorContext.MEMORY_MB, 512);
>   }
> {code}
> The above code when module is expanded attribute set on operator o1 is lost.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message