apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXCORE-272) Attributes added to operator inside Module is not preserved.
Date Thu, 31 Dec 2015 04:50:49 GMT

    [ https://issues.apache.org/jira/browse/APEXCORE-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075710#comment-15075710
] 

ASF GitHub Bot commented on APEXCORE-272:
-----------------------------------------

Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/191#discussion_r48646622
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
    @@ -1359,7 +1409,8 @@ private void addDAGToCurrentDAG(ModuleMeta moduleMeta)
         String name;
         for (OperatorMeta operatorMeta : subDag.getAllOperators()) {
           name = subDAGName + MODULE_NAMESPACE_SEPARATOR + operatorMeta.getName();
    -      this.addOperator(name, operatorMeta.getOperator());
    +      Operator op = this.addOperator(name, operatorMeta.getOperator());
    --- End diff --
    
    Are we keeping module DAG after adding it's operators to the final DAG? If not, there
is no meta object sharing between DAGs.
    Introducing copy constructor will allow to share some of final collection references.
As operator reference is shared between meta objects, should other references be also shared?




> Attributes added to operator inside Module is not preserved.
> ------------------------------------------------------------
>
>                 Key: APEXCORE-272
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-272
>             Project: Apache Apex Core
>          Issue Type: Bug
>            Reporter: Tushar Gosavi
>            Assignee: Tushar Gosavi
>
> Attributes added to operator within a Module is not preserved.
> for example
> {code}
> class M implements Module {
>   public void populateDAG(DAG dag, Configuration conf) {
>      DummyOperator o1 = dag.addOperator("O1", new DummyOperator());
>      o1.setOperatorProp(level1ModuleProp);
>      dag.getMeta(o1).getAttributes().put(Context.OperatorContext.MEMORY_MB, 512);
>   }
> {code}
> The above code when module is expanded attribute set on operator o1 is lost.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message