apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXCORE-272) Attributes added to operator inside Module is not preserved.
Date Wed, 30 Dec 2015 07:21:49 GMT

    [ https://issues.apache.org/jira/browse/APEXCORE-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074716#comment-15074716
] 

ASF GitHub Bot commented on APEXCORE-272:
-----------------------------------------

Github user tweise commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/191#discussion_r48589840
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
    @@ -907,6 +912,51 @@ else if (field.getType() == float.class || field.getType() == Float.class
||
             getValue(OperatorContext.METRICS_DIMENSIONS_SCHEME));
         }
     
    +    /**
    +     * Copy attribute from source attributeMap to destination attributeMap.
    +     *
    +     * @param dest  destination attribute map.
    +     * @param source source attribute map.
    +     */
    +    private void copyAttributes(AttributeMap dest, AttributeMap source)
    --- End diff --
    
    Shouldn't this be putAll on AttributeMap?


> Attributes added to operator inside Module is not preserved.
> ------------------------------------------------------------
>
>                 Key: APEXCORE-272
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-272
>             Project: Apache Apex Core
>          Issue Type: Bug
>            Reporter: Tushar Gosavi
>            Assignee: Tushar Gosavi
>
> Attributes added to operator within a Module is not preserved.
> for example
> {code}
> class M implements Module {
>   public void populateDAG(DAG dag, Configuration conf) {
>      DummyOperator o1 = dag.addOperator("O1", new DummyOperator());
>      o1.setOperatorProp(level1ModuleProp);
>      dag.getMeta(o1).getAttributes().put(Context.OperatorContext.MEMORY_MB, 512);
>   }
> {code}
> The above code when module is expanded attribute set on operator o1 is lost.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message