apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Priyanka Gugale <priya...@datatorrent.com>
Subject Re: Code style: Line length enforcement
Date Wed, 02 Dec 2015 06:13:23 GMT
+1 to have fixed length.
We need to check if there any way to help editors split the big strings in
better way.
Or for such exceptions, coder can format the part manually, adhering to the
length restriction and giving better readability.

-Priyanka

On Wed, Dec 2, 2015 at 11:36 AM, Pradeep A. Dalvi <apache@pradeepdalvi.com>
wrote:

> -1 for 120 hard stop. There should be guideline to follow 120 line length,
> not an enforcement.
> Few characters ahead of 120 limit shall be allowed, if otherwise
> compromises readability.
>
> On Wed, Dec 2, 2015 at 11:20 AM, Timothy Farkas <tim@datatorrent.com>
> wrote:
>
> > +1 to keep 120 line length. In my opinion it improves readability because
> > it allows you to read code by only scrolling up and down. If you mix
> having
> > to scroll up, down, left, and right into the mix it can become difficult
> to
> > read code.
> >
> > On Tue, Dec 1, 2015 at 9:38 PM, Vlad Rozov <v.rozov@datatorrent.com>
> > wrote:
> >
> > > +1 to keep 120 hard stop enforcement and not to rely on IDE formatting
> to
> > > find wrapping point. I agree that wrapping string literal not always
> help
> > > with readability, but overall I think that enforcing a hard stop on the
> > > line length help with writing better code especially after going
> through
> > an
> > > exercise of fixing all code style violations in the buffer server.
> > > Additionally some string literals may span multiple lines and will
> > require
> > > breaking anyway.
> > >
> > > Thank you,
> > >
> > > Vlad
> > >
> > >
> > > On 12/1/15 21:19, Thomas Weise wrote:
> > >
> > >> A while ago, we discussed max length for line length enforcement and
> > >> majority wanted to stop at 120 characters.
> > >>
> > >> Since then Vlad has fixed code style violations for one of the
> modules:
> > >>
> > >> https://github.com/apache/incubator-apex-core/pull/175
> > >>
> > >> Before we continue I would like to put the line length enforcement
> back
> > >> for
> > >> poll.
> > >>
> > >> I think it leads to undesirable results, such as breaking string
> > literals.
> > >> There are also instances of questionable readability gains and the
> > breaks
> > >> still have to be manually handled due to unwelcome IDE auto-format.
> > >>
> > >> My preference would be not not enforce a line length.
> > >>
> > >> Opinions please.
> > >>
> > >>
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message